Add support for Samsung devices #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove check for phonebook_sharing_message_confirm_pin as that isn't used on all devices. Added option of checking the message view in addition to the title to see if the device if a go plus. Changed logic to handle cases where either the title or message aren't used. OnePlus doesn't use message at all.
|
Hi thanks a lot for the fix! Regrettably, I haven't got around to look into it much. Have you tested it? |
|
I have tested with a Galaxy S22+ on Android 12 and a OnePlus 6T on Android 11. Those are the only 2 phones I have access to. |
|
That is awesome (and saves me a lot of trouble trying to borrow a Samsung phone to test it)! Will merge asap. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove check for phonebook_sharing_message_confirm_pin as that isn't used on all devices.
Added option of checking the message view in addition to the title to see if the device is a go plus.
Changed logic to handle cases where either the title or message aren't used. OnePlus doesn't use message at all.